feat(results): git-native storage — design doc + implementation#1261
Draft
christso wants to merge 18 commits into
Draft
feat(results): git-native storage — design doc + implementation#1261christso wants to merge 18 commits into
christso wants to merge 18 commits into
Conversation
Captures the agreed architecture before implementation: - Git is the canonical store; local clone is the working copy - No separate index file — git tree IS the index - Eval writes directly to clone working tree (not project-local .agentv/results/) - Reads via git ls-tree + git cat-file --batch (no checkout) - Pagination via cursor - mode: github explicit in config (extension point) Supersedes closed PR #1260. See docs/plans/git-native-results.md for full design. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
8b9e112
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bce10e3c.agentv.pages.dev |
| Branch Preview URL: | https://feat-git-native-results.agentv.pages.dev |
- Add `mode: 'github'` as required field to ResultsConfig - Repurpose `results.path` as optional local filesystem path for clone (default: ~/.agentv/results/<slug>/); reject old-style subdir values (e.g. 'runs') with a migration message - Rename ResultsRepoCachePaths → ResultsRepoLocalPaths - Rename getResultsRepoCachePaths → getResultsRepoLocalPaths - Rename cache_dir → local_dir in ResultsRepoStatus wire format - normalizeResultsConfig: fill default path, expand ~, include mode - Remove redundant local normalizeResultsConfig copy in remote.ts - Update config-validator.ts to enforce mode and filesystem-path rule - Update tests for new schema Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix biome string-concat lint error (single template literal) - resolveResultsRepoRunsDir: use normalized.path directly (new design) - getResultsRepoStatus: check existsSync(normalized.path) for available, set local_dir to normalized.path - serve.test.ts: update two tests to use mode:github schema and new default path layout (~/.agentv/results/<slug>/runs/...) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Added listGitRuns() using git ls-tree + cat-file --batch - Improved batch parser - Saved implementation goal document This is early progress toward the full git-native results implementation. More to come in follow-up commits.
- Enrich GitListedRun with display_name, test_count, avg_score, size_bytes - Update remote.ts mapping to populate ResultFileMeta fields - Read path now returns data Studio can render
- Add user: ${UID}:${GID} to docker-compose for mounted repo permissions
- Update goal document with current status
- Reinstall dependencies in worktree
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes closed PR #1260 (P1 append-only index approach). Implements issue #1259 with the design-pivoted architecture.
Summary
Replaces the per-manifest read bottleneck with a git-native model:
git ls-tree+git cat-file --batchfor listing (no checkout, no separate index file)Why a design pivot
P1 (PR #1260) introduced `index/runs.jsonl` as an append-only index. It worked but added a second source of truth that:
The cleaner approach: the git tree IS the index. `benchmark.json` already exists per run with all listing metadata. `git ls-tree` enumerates runs without reading any blob. `git cat-file --batch` reads existing `benchmark.json` blobs in one subprocess call. No new file, no drift, naturally prunes.
See `docs/plans/git-native-results.md` for the full design rationale and implementation breakdown.
Sub-task status under the new design
Breaking changes accepted
No production users yet, so breaking changes are acceptable. Documented in plan + release notes.
Implementation passes
See plan for details. Recommended order:
Test plan
Handoff notes for next agent
🤖 Generated with Claude Code